Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating some variables to be constexpr. #858

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Updating some variables to be constexpr. #858

merged 1 commit into from
Sep 16, 2023

Conversation

RealTimeChris
Copy link
Member

As it makes sense to have them as constexpr.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 16, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 2892eb8
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6505965f3eb8380008d26987
😎 Deploy Preview https://deploy-preview-858--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RealTimeChris
Updating some variables to be constexpr.
2892eb8 
As it makes sense to have them as constexpr.
Also updated the comments in isa_detection.h.
@raxyte raxyte added the enhancement New feature or request label Sep 16, 2023
@braindigitalis braindigitalis merged commit 748b7c7 into brainboxdotcc:dev Sep 16, 2023
29 checks passed
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
@RealTimeChris @Mishura4
Updating some variables to be constexpr. (brainboxdotcc#858)
11825e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxyte raxyte raxyte approved these changes

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RealTimeChris @braindigitalis @raxyte